enable scfg.restructure()
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esc
force-pushed
the
refactor_transforms
branch
from
c7f9f21
to
6e30edb
Compare
sklam
reviewed
Apr 16, 2024
There was a problem hiding this comment.
The change is straightforward code moving and minor modification.
The pre-commit hook is complaining about rendering.py though: https://github.com/numba/numba-rvsdg/actions/runs/8706874067/job/23880512661?pr=112#step:5:53
This moves the loop and branch restructuring code from the `ByteFlow` class to the `SCFG` class. The `ByteFlow` class is scheduled for eventual deletion anyway -- so this is a first step in that direction. This is needed now, such that `SCFG` generated from Python abstract syntax trees can also be transformed.
esc
force-pushed
the
refactor_transforms
branch
from
6e30edb
to
72a2a42
Compare
As title
As title
fixed. |
sklam
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the loop and branch restructuring code from the
ByteFlowclass to theSCFGclass. TheByteFlowclass is scheduled for eventual deletion anyway -- so this is a first step in that direction.This is needed now, such that
SCFGgenerated from Python abstract syntax trees can also be transformed.